Make the translation item collector handle *uses* of 'const' items instead of declarations. #35534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 66e3a71 has been approved by |
|
@bors p=1 -- regression |
|
⌛ Testing commit 66e3a71 with merge bc2f91a... |
|
💔 Test failed - auto-mac-64-opt-rustbuild |
|
It seems this needs a rebase ... |
…stead of declarations.
michaelwoerister
force-pushed
the
fix-const-collection2
branch
from
66e3a71 to
09e73a5
Compare
|
@bors r=nikomatsakis p=1 Passes make check locally... |
|
📌 Commit 09e73a5 has been approved by |
|
⌛ Testing commit 09e73a5 with merge ff8d40b... |
|
💔 Test failed - auto-linux-64-debug-opt |
|
Another timeout |
|
See #35628 about the timeouts. |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Aug 14, 2016
…matsakis Make the translation item collector handle *uses* of 'const' items instead of declarations. This should fix issue #34754.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #34754.